[Reference] [UserPassword] Use the non-deprecated class for Symfony 2.2 #2297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the removed trailing whitespaces in the same commit, but I think it's worth merging them as well after all. |
|
👍 Please add a |
|
@wouterj Fixed |
| `Symfony\Component\Security\Core\Validator\Constraints` namespace since | ||
| Symfony 2.2. The `UserPassword` defined in the | ||
| `Symfony\Component\Security\Core\Validator\Constraint` namespace is | ||
| deprecated and will be removed in Symfony 2.3. |
There was a problem hiding this comment.
I think it is better to use something like:
Since Symfony 2.2, the `UserPassword*` classes in the
``Symfony\Component\Security\Core\Validator\Constraint``
namespace is depecreated and will be removed in Symfony 2.3.
Please use the `UserPassword*` classes in the
``Symfony\Component\Security\Core\Validator\Constraints``
namespace instead.
|
@wouterj Sounds better with your sentence. I replaced mine with yours with just a few tweaks. |
|
Ok, thank you for the quick response, good catch and nice PR! |
|
You're welcome! Thanks for your help |
weaverryan
added a commit
that referenced
this pull request
Mar 12, 2013
[Reference] [UserPassword] Use the non-deprecated class for Symfony 2.2
|
Very nice guys - thanks Michaël and WouterJ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.