Skip to content

Fixed plural version of URLs where it was referred to as "URL's" #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2013

Conversation

caponica
Copy link
Contributor

A simple fix to a couple of typos in the documentation. It's my first time sending a pull request to a github repo so I hope I've done it right. If all ok there are lots more typos/grammar bits I can update.

Q A
Doc fix? yes ? (Fixes typos, not sure if this is the meaning of "Doc fix")
New docs? no
Applies to all
Fixed tickets none

@wouterj
Copy link
Member

wouterj commented Mar 15, 2013

👍 great catches and nice to see someone who read the contributing docs :)

@caponica
Copy link
Contributor Author

Well, I just finished reading the book cover to cover - I don't think I'd be qualified to fix it if I hadn't read it :)

@caponica
Copy link
Contributor Author

Hi - this is my first time issuing a pull request... does the status update on this page when it's been accepted? I have a lot more edits to make but want to be sure I'm following the right procedure before working through them all!

@wouterj
Copy link
Member

wouterj commented Mar 20, 2013

@caponica yes, you're doing it perfect! It's good to see person who wants to get involved in the docs! So: please request more changes! 👍

However, @weaverryan is the (co-)author of the documentation. If he has some time, he will go through the PR queue and merge PRs. You get a notification when that's done (and this PR will be closed automatically).

weaverryan added a commit that referenced this pull request Mar 30, 2013
Fixed plural version of URLs where it was referred to as "URL's"
@weaverryan weaverryan merged commit ceeb1b2 into symfony:2.0 Mar 30, 2013
@weaverryan
Copy link
Member

Love it, great PR! Keep them coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants