Skip to content

removed deprecated features #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 30, 2013
Merged

removed deprecated features #2344

merged 8 commits into from
Mar 30, 2013

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Mar 23, 2013

Q A
Doc fix? no
New docs? no
Applies to 2.3
Fixed tickets #2298

@@ -1,214 +0,0 @@
Callback
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing this doc ? It is not deprecated AFAIK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - the CallbackValidator (the one in the Form component) was deprecated, but not the Callback constraint in the Validator component afaik. We don't have any documentation for the CallbackValidator in the Form component.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted, thanks.

@weaverryan weaverryan merged commit 934531c into symfony:master Mar 30, 2013
@weaverryan
Copy link
Member

Hi guys!

I've merged this into master, with a few highlights:

  • Backported some of these changes to 2.1 at sha: 851c35a
  • Fixed lifetime to cookie-lifetime instead of session-lifetime, which I think was a mistake here also at sha: 851c35a. This was merged up and replaces the session-lifetime in this commit

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants