Skip to content

Improve serialization example #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Improve serialization example #2402

wants to merge 1 commit into from

Conversation

tvlooy
Copy link
Contributor

@tvlooy tvlooy commented Mar 30, 2013

Improve serialization example

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #2225

Improve serialization example

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #2225
@stof
Copy link
Member

stof commented Mar 30, 2013

new docs: yes ? this is not adding new doc but only fixing existing one.

@tvlooy
Copy link
Contributor Author

tvlooy commented Mar 30, 2013

I saw it as an extension and thereby something new. Changed now.

@wouterj
Copy link
Member

wouterj commented Mar 30, 2013

It doesn't make much sense. I also think it's a new docs.

@tvlooy
Copy link
Contributor Author

tvlooy commented Mar 30, 2013

Well, does it matter?

@Sgoettschkes
Copy link
Contributor

👍

@weaverryan
Copy link
Member

Awesome job Tom - another PR merged, issue closed.

I've patched this into the 2.0 branch at sha: 1a8d0dc

Thanks!

@weaverryan weaverryan closed this Mar 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants