Skip to content

[WIP][Cookbook] Document how to install 3th party bundles #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2013
Merged

[WIP][Cookbook] Document how to install 3th party bundles #2404

merged 5 commits into from
Mar 31, 2013

Conversation

pvolok
Copy link
Contributor

@pvolok pvolok commented Mar 30, 2013

Q A
Doc fix? yes
New docs? yes
Applies to 2.1+
Fixed tickets #2176

Based ob this answer by Wouter J: http://stackoverflow.com/questions/13338692/how-do-you-register-bundles-in-symfony2-1-designed-for-older-versions-of-symfony/13340180#13340180

I used FOSUserBundle for an example as it is wider known.

For config:dump-reference command i used AsseticBundle because FOSUserBundle requires more effort to start working (mainly creating model classes). And it will be easier for new users to test with AsseticBundle.

steps are common for any bundle.

Add composer dependencies
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 ~ to much

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be dashed

How to install 3rd party bundles
================================

Most bundles provide a documentation of installation. However, most
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most bundles provide their own installation instructions.

How to install 3rd party bundles
================================

Most bundles provide their own installation instructions. However the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the

`Packagist`_ package of that bundle. For example, for the
`FOSUserBundle`_ you should look for a
``friendsofsymfony/user-bundle`` package and it does exists:
https://packagist.org/packages/friendsofsymfony/user-bundle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we get some conflict with the dot here. Add a space between the link and the dot

...,
"require": {
...,
"friendsofsymfony/user-bundle": "dev-master"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflict with the fact that you mention 1.3 above. FOSUserBundle dev-master is not 1.3 but 2.0.x-dev

And please don't advocate the dev-master requirement. As soon as a bundle provides a branch alias, it is better to use it rather than requiring dev-master. It will be safer if the bundle introduces a BC break in master (assuming they bump the branch alias properly of course).

So here, you should be requiring either 1.3.* or 2.0.*@dev

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, Packagist uses the branch alias when displaying the require statement for the package version when it exists.

weaverryan added a commit that referenced this pull request Mar 31, 2013
[WIP][Cookbook] Document how to install 3th party bundles
@weaverryan weaverryan merged commit d839c3b into symfony:2.1 Mar 31, 2013
weaverryan added a commit that referenced this pull request Mar 31, 2013
@weaverryan
Copy link
Member

Hi Pavel!

Really nice work here! I proofread it and made some tweaks (at sha: c4b754e), but it's quite good. If you notice any issues in my changes, please let me know!

Thanks!

@pvolok pvolok deleted the cookbook_bundles_installation branch April 2, 2013 12:32
@pvolok
Copy link
Contributor Author

pvolok commented Apr 3, 2013

@weaverryan Hi Ryan. Thank you!

I checked the docs on symfony.com, and I can see this topic in 2.1 (but not in 2.2+) so I guess that the "next weekly release" has happened. On the other hand, the Contributing guide tells that commits are going to be propagated up on every release. Looks like I don't understand something. I'm going to keep contributing so would be nice to clearly understand this nuance.

@wouterj
Copy link
Member

wouterj commented Apr 3, 2013

We need to merge the branches ourselves. That means that Ryan is doing that around once a week. Some times, you need to wait longer, sometimes you're lucky :)
The doc parser runs at 3 AM european time and the article when then be visibile on the site.

However, you're document isn't lost. You will see it on the site soon :)

@pvolok
Copy link
Contributor Author

pvolok commented Apr 3, 2013

Ah, now it's clear. Thanks Wouter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants