Skip to content

[book] [controller] Added documentation for static pages #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

saro0h
Copy link
Contributor

@saro0h saro0h commented Mar 30, 2013

No description provided.


.. versionadded:: 2.2
The ``FrameworkBundle:Template:template`` internal controller is new in
Symfony 2.2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! It's actually not new in Symfony 2.2 (it's always been here) - only the ability to cache is new in 2.2.

@weaverryan
Copy link
Member

Hi Sarah!

As you saw (because you have a nice link to it at the bottom) - this is already documented in a cookbook article. However, I really like the idea of adding something to the book so that it's quite findable, and I think the title you've chosen for this section is great. To avoid duplication (and to keep these long book articles as short as possible), I'd like to remove the example you've included here and basically just tell the user that this is very easy and possible, and include the link to the cookbook article. If there are some changes that you'd like to make to the language in that article, I'd love to see those as well.

Thanks!

@saro0h
Copy link
Contributor Author

saro0h commented Apr 4, 2013

Here it is! I also did the french translation here : symfony-fr/symfony-docs-fr#229 (I don't know if it's the right way to do it). Is that ok?

The ability to cache templates rendered via ``FrameworkBundle:Template:template``
is new in Symfony 2.2.

Use it ! See :doc:`cookbook/templating/render_without_controller`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to put this line after the paragraph.

The versionadded block should be above the title aswell

@wouterj
Copy link
Member

wouterj commented Apr 4, 2013

@saro0h the translated repositories keep an eye on this main repository and try to keep in sync with this repo. I think they will really appreciate it if you help them with a PR on their repo :)


.. versionadded:: 2.2
The ability to cache templates rendered via ``FrameworkBundle:Template:template``
is new in Symfony 2.2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed as this section is not talking about caching them anymore (this is documented in the cookbook)

weaverryan added a commit that referenced this pull request Apr 9, 2013
@weaverryan
Copy link
Member

Hey Sarah!

I've patched your commits into the 2.0 branch (since they should affect all branches) and everything look good.

Thanks for your contribution!

@weaverryan weaverryan closed this Apr 9, 2013
@saro0h saro0h deleted the static-controller branch January 26, 2014 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants