Facelift for book/routing - "Easy" level #2431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix DomCrawler html dumping example.
Fixed plural version of URLs where it was referred to as "URL's"
[Config][Normalization] added a tip about altered keys
Fixed a yaml configuration block
Removing an unused use statement from example
|
looks like you selected the wrong target when creating the PR |
|
Closing this PR - it's been replaced by #2436 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall, I feel this book page is well written and straightforward. I made a few minor changes.
I feel that using annotations for routing was easy to miss, so I gave it a subheading instead of a "Note".
I also added a short description for the command "router:match".