[WIP] re-read of http-foundation component docs #2435
Conversation
|
|
||
| * ``server``: equivalent of ``$_SERVER``; | ||
|
|
||
| * ``headers``: mostly equivalent to a sub-set of ``$_SERVER`` | ||
| (``$request->headers->get('Content-Type')``). | ||
| (``$request->headers->get('user-agent')``). |
There was a problem hiding this comment.
You're right. Content-type could be used on a POST or PUT. Might I suggest that user-agent still could be a better choice since all requests are likely to have this. If someone is trying out code samples, they might be confused why content-type is coming up null. What do you think?
There was a problem hiding this comment.
Both are good, so I'm cool with user agent. But I think we should have it be User-Agent - it's true that case doesn't matter when getting the headers, but User-Agent may be a little more recognizable as a header.
There was a problem hiding this comment.
Ok, I will make the change. I'm also planning on picking this back up over the weekend to finish the WIP. Thanks for the feedback.
|
Ping @joelclermont! Let me know what your plans are with this - you already have some nice changes here. Cheers! |
|
Wow, time has gotten away from me. My plan is to finish up the doc review completely, hopefully in the next week. Thanks for the reminder. |
[WIP] re-read of http-foundation component docs
|
Hey Joel! I've merged this in because you had a lot of nice changes :). I know you wanted to do a bit more and hopefully someday you will ;). Thanks again for joining us during the doc-day. Cheers! |
|
Thanks Ryan. Let me know when the next doc day is and I'd love to participate. I'm still trying to carve out more time in between 😄 |
Just getting started, but I wanted to submit some example commits as a WIP for early feedback. I'm also posting some questions/comments in the issue thread.