[cookbook][form][dynamic] DataEvent is deprecated in favor of FormEvent #2463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| FormEvents::PRE_BIND => 'preBind', | ||
| FormEvents::PRE_SET_DATA => 'preSetData', | ||
| ]; | ||
| ); |
There was a problem hiding this comment.
the [] syntax is php 5.4 only, as long as we support 5.3 we should not confuse people with examples that don't work for them.
|
Hi guys! This is a bit of my fault - I merged in a big change to this document (which included all of these issues) and then made a big fix for them in #2417, which I just merged in. But @dbu I'm happy that you actually read the entry and took time to fix our mistakes (and these were indeed all legitimate issues). The whole entry should be in much better shape now (though I have more changes needed in #2464). Thanks! |
|
i was actually looking for an existing pull request when i did this but for whatever reason did not see it. anyways, thanks for making the doc better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems this has slipped the corrections applied elsewhere in this file.