Skip to content

Document start on demand feature. #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from Apr 29, 2013
Merged

Document start on demand feature. #2475

merged 6 commits into from Apr 29, 2013

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2013

Q A
Doc fix? yes
New docs? yes (symfony/symfony#7576)
Applies to all (or 2.3+)
Fixed tickets na

@ghost ghost mentioned this pull request Apr 6, 2013
Merged
stof
stof reviewed Apr 6, 2013
View reviewed changes
reference/configuration/framework.rst
@@ -26,6 +26,8 @@ Configuration
* enabled
* field_name
* `session`_
* `auto_start`_
* `on_demand`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about mock_name ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should link to headings explaining these options. If you don't add a section about these options, it should be:

* `session`_
    * auto_start
    * on_demand

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@stof
Copy link
Member

stof commented Apr 6, 2013

Please use the doc PR format: http://symfony.com/doc/current/contributing/documentation/overview.html#pull-request-format

wouterj
wouterj reviewed Apr 6, 2013
View reviewed changes
components/http_foundation/session_configuration.rst
any attempt was made to access session data (effectively 'start on demand').
From Symfony 2.3 this behaviour can be controlled.

There are three modes defined by :class:`Symfony\\Component\\HttpFoundation\\Session\\Storage\\SessionStorageInterface`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the class role on a new line, to not break or 72th line wrapping rule.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

fabpot
fabpot reviewed Apr 11, 2013
View reviewed changes
components/http_foundation/session_configuration.rst
- ``SessionStorageInterface::NO_START_ON_DEMAND_STRICT`` - The session will not be started on demand
and any attempt to read or write session data will result in a ``\RuntimeException``
- ``SessionStorageInterface::START_ON_DEMAND`` - The session will be started if it hasn't already been
when any attempt is made to read ro write session data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ro instead of or.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

fabpot added a commit to symfony/symfony that referenced this pull request Apr 18, 2013
@fabpot
merged branch drak/start_on_demand (PR #7576)
7aa0681 
This PR was merged into the master branch.

Discussion
----------

[2.3][Session] Give greater control over how and when session starts

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | na
| License       | MIT
| Doc PR        | symfony/symfony-docs#2475

Refs #6036

Gives control over how start on demand works: allowing to turn it on or off and to allow bag access when session is off.

Commits
-------

f431cb0 Fix tests
1f521d8 Coding standards
2583c26 [HttpFoundation][FrameworkBundle] Keep save auto_start behaviour as in 2.2 and make component values consistent with FrameworkBundle's configuration options.
ceaf69b [FrameworkBundle] Use more sophisticated validation and configuration.
af0a140 [FrameworkBundle] Add configuration to allow control over session start on demand.
8fc2397 [HttpFoundation] Give control over how session start on demand.
fabpot added a commit to symfony/http-foundation that referenced this pull request Apr 18, 2013
@fabpot
merged branch drak/start_on_demand (PR #7576)
c21c53a 
This PR was merged into the master branch.

Discussion
----------

[2.3][Session] Give greater control over how and when session starts

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | na
| License       | MIT
| Doc PR        | symfony/symfony-docs#2475

Refs #6036

Gives control over how start on demand works: allowing to turn it on or off and to allow bag access when session is off.

Commits
-------

f431cb0 Fix tests
1f521d8 Coding standards
2583c26 [HttpFoundation][FrameworkBundle] Keep save auto_start behaviour as in 2.2 and make component values consistent with FrameworkBundle's configuration options.
ceaf69b [FrameworkBundle] Use more sophisticated validation and configuration.
af0a140 [FrameworkBundle] Add configuration to allow control over session start on demand.
8fc2397 [HttpFoundation] Give control over how session start on demand.
fabpot added a commit to symfony/framework-bundle that referenced this pull request Apr 18, 2013
@fabpot
merged branch drak/start_on_demand (PR #7576)
31c18d3 
This PR was merged into the master branch.

Discussion
----------

[2.3][Session] Give greater control over how and when session starts

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | na
| License       | MIT
| Doc PR        | symfony/symfony-docs#2475

Refs #6036

Gives control over how start on demand works: allowing to turn it on or off and to allow bag access when session is off.

Commits
-------

f431cb0 Fix tests
1f521d8 Coding standards
2583c26 [HttpFoundation][FrameworkBundle] Keep save auto_start behaviour as in 2.2 and make component values consistent with FrameworkBundle's configuration options.
ceaf69b [FrameworkBundle] Use more sophisticated validation and configuration.
af0a140 [FrameworkBundle] Add configuration to allow control over session start on demand.
8fc2397 [HttpFoundation] Give control over how session start on demand.
@ghost ghost mentioned this pull request Apr 26, 2013
Closed
weaverryan added a commit that referenced this pull request Apr 29, 2013
@weaverryan
Merge pull request #2475 from drak/session_demand
bd3e58e 
[WCM] Document start on demand feature.
@weaverryan weaverryan merged commit bd3e58e into symfony:master Apr 29, 2013
weaverryan added a commit that referenced this pull request Apr 29, 2013
@weaverryan
[#2475] Tweaks to new session on-demand docs
7f288dc
@weaverryan
Copy link
Member

Very very nice job Drak - thanks!

@ghost
Copy link
Author

ghost commented Apr 30, 2013

Looks like you'll have to revert this because @fabpot wont merge for 2.3 it seems :(

weaverryan added a commit that referenced this pull request Apr 30, 2013
@weaverryan
Revert "[#2475] Tweaks to new session on-demand docs"
c2bb5a0 
This reverts commit 7f288dc.

Reverted because the code change was reverted.
weaverryan added a commit that referenced this pull request Apr 30, 2013
@weaverryan
Revert "Merge pull request #2475 from drak/session_demand"
94d11ef 
This reverts commit bd3e58e, reversing
changes made to 73e5095.

Reverted because the code change was reverted
@weaverryan
Copy link
Member

Ah, thanks Drak - I didn't see the code revert!

Reverted at sha: c2bb5a0 and sha: 94d11ef

Thanks!

fabpot added a commit to symfony/framework-bundle that referenced this pull request Nov 11, 2014
@fabpot
merged branch drak/start_on_demand (PR #7576)
82ad4ae 
This PR was merged into the master branch.

Discussion
----------

[2.3][Session] Give greater control over how and when session starts

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | na
| License       | MIT
| Doc PR        | symfony/symfony-docs#2475

Refs #6036

Gives control over how start on demand works: allowing to turn it on or off and to allow bag access when session is off.

Commits
-------

f431cb0 Fix tests
1f521d8 Coding standards
2583c26 [HttpFoundation][FrameworkBundle] Keep save auto_start behaviour as in 2.2 and make component values consistent with FrameworkBundle's configuration options.
ceaf69b [FrameworkBundle] Use more sophisticated validation and configuration.
af0a140 [FrameworkBundle] Add configuration to allow control over session start on demand.
8fc2397 [HttpFoundation] Give control over how session start on demand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stof @weaverryan @fabpot @staabm @wouterj