Skip to content

Refactored Doc standards #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2013
Merged

Refactored Doc standards #2481

merged 4 commits into from
Apr 30, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Apr 7, 2013

Q A
Doc fix? yes
New docs? yes
Applies to all
Fixed tickets -

I spoke the CMF guys (mainly @dbu ) this weekend and they are going to follow our documentation standards. Now it's used in more project, I've moved it outside the overview document and inside it's own document.

There are also some other things which needs some discussion (things that are added in this PR are things that I and the CMF guys like to see in the standards, but if people are -1 for it, it gets removed):

  • Added standards on which characters to use for heading levels - Sphinx doesn't have specific level specific character, they should be documented somewhere
  • Added a standard about inline hyperlinks vs the once we use
  • Added standards about the needed formats - Without this, all @ricardclau's and my work needs to get done again 😉

@pvolok
Copy link
Contributor

pvolok commented Apr 8, 2013

After writing some docs it feels painful to add links. For instance, if I want to write something like "you can read more here".

Is there a way writing like:

read `here<alias>`_

...

.. _`alias`: http://...

shorthand);
* Inline hyperlinks are **not** used. Seperate the link and their target
definition, which you add on the bottom of the page;
* You should use a form of *you* instead of *we*.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about an example below all of this that shows these rules in action (as much as possible).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that. I need to think of a good example, it's hard to put most standards in one example without the example being to dummy... :)

@weaverryan
Copy link
Member

Very nice changes Wouter! Don't forget the map and index changes for the new doc.

I have no problems with the 3 items you listed above - we're already been doing these things, I think it's great to formalize it.

@wouterj
Copy link
Member Author

wouterj commented Apr 23, 2013

@pvolok I had a look into the ReSt and Sphinx specs, but it's not possible. The only thing that's possible is using anonymous targets, but that makes the doc even unreadable :)

@wouterj
Copy link
Member Author

wouterj commented Apr 24, 2013

@weaverryan I added an example, fixed some things and squashed the commits. It's ready for merging now

weaverryan added a commit that referenced this pull request Apr 30, 2013
@weaverryan weaverryan merged commit 8c042f1 into symfony:2.0 Apr 30, 2013
weaverryan added a commit that referenced this pull request Apr 30, 2013
@weaverryan
Copy link
Member

Nice work @wouterj! I think having this in its own document is certainly more clear. Very minor tweaks at sha: 0d055a2

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants