Skip to content

[cookbook][logging]Bug in xml monolog format example #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2013
Merged

[cookbook][logging]Bug in xml monolog format example #2488

merged 1 commit into from
May 3, 2013

Conversation

burci
Copy link
Contributor

@burci burci commented Apr 11, 2013

Changed \n => 
 in xml example.

Changed \n => 
 in xml example.
@burci
Copy link
Contributor Author

burci commented Apr 11, 2013

Hm, well i dont know if this will be good at the site, or should i write as 
 in the code?

@wouterj
Copy link
Member

wouterj commented Apr 11, 2013

I actually can't see the problem? When I view it in the browser, everything is correct.

The Sphinx parser will already take care of escaping characters

@burci
Copy link
Contributor Author

burci commented Apr 11, 2013

When i write it down here in markdown it did not escaped well, but then everything is fine with this patch.

@stof
Copy link
Member

stof commented Apr 11, 2013

@burci The doc is not written in Markdown

@burci
Copy link
Contributor Author

burci commented Apr 11, 2013

@stof I mean when I opened the ticket here at github, I had to change the description because of 
 not escaped well. That makes me think that maybe the same can happen with reST, but since then i checked and it is correct in this way.

@stof
Copy link
Member

stof commented Apr 11, 2013

@burci you had to change the description because you are not using a Markdown code-block...

@burci
Copy link
Contributor Author

burci commented Apr 11, 2013

@stof true

weaverryan added a commit that referenced this pull request May 3, 2013
[cookbook][logging]Bug in xml monolog format example
@weaverryan weaverryan merged commit 1119674 into symfony:2.0 May 3, 2013
@weaverryan
Copy link
Member

Hey Peter!

Wow, very subtle fix, but you're absolutely right: the new change you make breaks perfectly in XML.

Thanks!

@burci burci deleted the bug-xml-newline branch May 3, 2013 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants