[WCM] document the doctrine compiler pass #2507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you please at the pull request format to your PR? |
| .. note:: | ||
|
|
||
| When building a reusable bundle, model classes should be placed in the | ||
| ``Model`` namespace. See doc:`../doctrine/mapping_model_classes` for |
There was a problem hiding this comment.
use /cookbook/doctrine/mapping_model.classes
|
|
||
| In your bundle class, write the following code to register the compiler pass:: | ||
|
|
||
| use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\DoctrineOrmMappingsPass; |
There was a problem hiding this comment.
this is still a bit too long. should i break it as well? and if so, how?
There was a problem hiding this comment.
@dbu no, namespaces (and CLI commands) are exceptions on this 85 characters rule. They can't be wrapped.
|
i added doc for mongodb, it should now become visible how this thing is going to work. |
weaverryan
added a commit
that referenced
this pull request
May 3, 2013
[WCM] document the doctrine compiler pass
weaverryan
added a commit
that referenced
this pull request
May 3, 2013
|
Hi David! Nice docs PR for a very nice feature. I only made very minor tweaks. Thanks! |
|
thanks. i will do a new PR once i add this to doctrine phpcr-odm too. the doctrine couchdb bundle is not really usable (tests failing, wants symfony 2.1 max) so for now nothing will happen with it, i fear. |
ondrejmirtes
pushed a commit
to ondrejmirtes/symfony
that referenced
this pull request
Nov 25, 2013
This PR was squashed before being merged into the master branch (closes symfony#7599). Discussion ---------- [Doctrine-Bridge] add a base compiler pass class to register doctrine mappings | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | not on code, but defining best practices | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#2507 Reusable bundles providing model classes should not rely on the automapping provided by the doctrine bundles. What is more, the same model can often be mapped to Doctrine ORM, MongoODM, CouchODM and PHPCR-ODM. This pull request adds a base class for a compiler pass that the concrete doctrine bundles extend to provide a default compiler pass that makes it trivial for bundles to register their mappings. See doctrine/DoctrineBundle#177 The FOSUserBundle shows how this would look in practice. See FriendsOfSymfony/FOSUserBundle#1081 I will create the documentation pull request as well as pull requests for the mongo, couch and phpcr bundles once we agree how exactly to do this. Commits ------- 099fd9f [Doctrine-Bridge] add a base compiler pass class to register doctrine mappings
ondrejmirtes
pushed a commit
to ondrejmirtes/symfony
that referenced
this pull request
Nov 25, 2013
This PR was merged into the master branch. Discussion ---------- fix register mappings pass to only register mappings with one object manager | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes (but feature is totally new) | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#7599 | License | MIT | Doc PR | symfony/symfony-docs#2507 This PR fixes the issues @stof discovered in symfony#7599 - we now introduce a way to only register the mappings with one of the object managers. Commits ------- fc12bd1 fix register mappings pass to only register mappings with one object manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if this should go to master or the 2.2 branch? the feature is not yet merged.