Skip to content

Document ignoreUnreadableDirs #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2013
Merged

Document ignoreUnreadableDirs #2576

merged 1 commit into from
May 4, 2013

Conversation

tvlooy
Copy link
Contributor

@tvlooy tvlooy commented Apr 29, 2013

Q A
Doc fix? no
New docs? yes
Applies to 2.3+
Fixed tickets #2574

wouterj
wouterj reviewed Apr 29, 2013
View reviewed changes
components/finder.rst

$finder->ignoreUnreadableDirs()->in(__DIR__);

.. versionadded:: 2.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always prefer to have the versionadded directive before the feature docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, fixed it. Question though, is there a rule that says when to use versionadd and when not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's documented here: http://symfony.com/doc/current/contributing/documentation/overview.html#documenting-new-features-or-behavior-changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@tvlooy
Document ignoreUnreadableDirs
2bc754d 
| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3
| Fixed tickets | 2574
weaverryan added a commit that referenced this pull request May 4, 2013
@weaverryan
Merge pull request #2576 from tvlooy/patch-8
c0a09d2 
Document ignoreUnreadableDirs
@weaverryan weaverryan merged commit c0a09d2 into symfony:master May 4, 2013
weaverryan added a commit that referenced this pull request May 4, 2013
@weaverryan
[#2576] Tweaks to Finder::ignoreUnreadableDirs docs
27dbceb
@weaverryan
Copy link
Member

Great job Tom - thanks!

@tvlooy tvlooy deleted the patch-8 branch December 15, 2013 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvlooy @weaverryan @wouterj