Skip to content

[cookbook][doctrine] fixed reverse_engineering doc #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2013

Conversation

77web
Copy link
Contributor

@77web 77web commented Apr 30, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.1+
Fixed tickets N/A

Sorry but I could find no evidence of update from the code.
I wrote the way that actually works for me (in Symfony SE 2.1/2.2).
If the evidence for this fix is required, I will dig into code...
Maybe they are in doctrine/DoctrineBundle or doctrine/orm?

@wouterj
Copy link
Member

wouterj commented Apr 30, 2013

I did no further research, but the code for the command can be found in the doctrinebindle: https://github.com/doctrine/DoctrineBundle/blob/master/Command/Proxy/ConvertMappingDoctrineCommand.php

@77web
Copy link
Contributor Author

77web commented Apr 30, 2013

@wouterj Thanks!
The method "getExporter()" in that class describes 9f2fb49.

weaverryan added a commit that referenced this pull request Jun 4, 2013
[cookbook][doctrine] fixed reverse_engineering doc
@weaverryan weaverryan merged commit 02c73c2 into symfony:2.1 Jun 4, 2013
@77web 77web deleted the fix-reverse_engineering-doc branch June 4, 2013 03:11
weaverryan added a commit that referenced this pull request Jun 4, 2013
@weaverryan
Copy link
Member

Hi Hiromi!

These are all excellent changes - I just worked through the exercises to verify :).

Thanks very much for your contribution!

@77web
Copy link
Contributor Author

77web commented Jun 4, 2013

Thank you for your kind help, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants