Skip to content

Documented dumpFile #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2013
Merged

Documented dumpFile #2592

merged 1 commit into from
May 5, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented May 3, 2013

Q A
Doc fix? no
New docs? yes ( symfony/symfony#7753
Applies to 2.3+
Fixed tickets #2531

@wouterj wouterj mentioned this pull request May 3, 2013
Closed
1 task
mpdude
mpdude reviewed May 3, 2013
View reviewed changes
components/filesystem.rst
@@ -227,6 +227,20 @@ isAbsolutePath returns true if the given path is absolute, false otherwise::
// return false
$fs->isAbsolutePath('../dir');

.. versionadded:: 2.1
``dumpFile`` was new in the Filesystem component in Symfony 2.1,
previously it could be found in ``CacheFileUtils``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dumpFile is new on master (Symfony 2.3).

"CacheFileUtils" is a class that exists only in a PR of mine but it was never official. Fabien suggested moving the code from there to Filesystem, so I would just remove this versionadded-note.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mpdude
Copy link
Contributor

mpdude commented May 3, 2013

Thanks for opening this PR! It reminds me that I should have documented that :-(.

@wouterj
Copy link
Member Author

wouterj commented May 3, 2013

don't worry, most of the things I contribute should be done by other people :)

weaverryan added a commit that referenced this pull request May 5, 2013
@weaverryan
Merge pull request #2592 from WouterJ/issue_2531
05f1aaf 
Documented dumpFile
@weaverryan weaverryan merged commit 05f1aaf into symfony:master May 5, 2013
weaverryan added a commit that referenced this pull request May 5, 2013
@weaverryan
[#2592] Minor tweaks for Filesystem::dumpFile
80c3fb3
@weaverryan
Copy link
Member

Awesome feature - thanks for picking up the docs Wouter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @mpdude @weaverryan