Skip to content

[WCM] Documented that "empty_value" can be used for expanded choice fields #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

webmozart
Copy link
Contributor

Q A
Doc fix? yes
New docs? yes (symfony/symfony#7939)
Applies to 2.3+
Fixed tickets -

@@ -3,9 +3,14 @@ empty_value

**type**: ``string`` or ``Boolean``

.. versionadded:: 2.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must remove this empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we keep an empty line after other control clauses then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the versionadded directive is a strange directive which can't handle a new line after it. All other directive can.

fabpot added a commit to symfony/symfony that referenced this pull request May 6, 2013
This PR was merged into the master branch.

Discussion
----------

[Form] Added radio button for empty value to expanded single-choice fields

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #3154
| License       | MIT
| Doc PR        | symfony/symfony-docs#2605

Commits
-------

7933971 [Form] Added radio button for empty value to expanded single-choice fields
weaverryan added a commit that referenced this pull request Jun 4, 2013
@weaverryan
Copy link
Member

Thanks Bernhard! Patched into the 2.3 branch at sha: 8e66fb1 with minor tweaks thanks to @craue and @wouterj at sha: ce74b62

Thanks everyone!

@weaverryan weaverryan closed this Jun 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants