Fix coding standards #2644
Fix coding standards #2644
Conversation
| @@ -49,11 +49,11 @@ example containing most features described below: | |||
|
|
|||
| /** | |||
| * @param string $dummy Some argument description | |||
| * @param array $options | |||
| * @param array $options | |||
There was a problem hiding this comment.
I'm not sure about this change. In the Symfony coding standards (http://symfony.com/doc/current/contributing/code/standards.html), the example shown does not include lining up the parameters. I'm also not sure if this is addressed specifically in PSR1 or PSR2. Is there a standard somewhere for this?
Thanks!
There was a problem hiding this comment.
First of all, we are talking about the example in contributing/code/standards, so of course does the current example not show that :)
And to answer you question: It's done in all comments in the source code. It's also part of the, never finished, Symfony2 PHPdoc standards: symfony/symfony#4183
There was a problem hiding this comment.
Ha, of course - that's really funny :). Thanks @wouterj!
|
Patched into the 2.1 branch at sha: ab1a1fa Thanks! |
|
@weaverryan can you patch all 2.* branches or do I need to submit PR on all branches ? |
|
It'll be fine. That's done once in a week or something like that |
No description provided.