Book/Form : Adding a new section about defining forms as service #2667
Conversation
gregquat
commented
May 27, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | all |
| Fixed ticket | - |
| Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed ticket | -
| @@ -833,6 +833,78 @@ form "type"). It can be used to quickly build a form object in the controller:: | |||
| // ... | |||
| } | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| Defining your form as a service is a good practice and make it easily usable in | |||
There was a problem hiding this comment.
You're defining your form type as a service, not your form
There was a problem hiding this comment.
I specified below "you must tag your form as a form type", do you think I should also change the first sentence?
There was a problem hiding this comment.
A FormType is not a form, but a Type of a form.
There was a problem hiding this comment.
Yea. I think you can just drop the second sentence if you fix the first one and then replace occurrences of the word "form" with the words "form type" further on
| @@ -833,6 +833,78 @@ form "type"). It can be used to quickly build a form object in the controller:: | |||
| // ... | |||
| } | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| Defining your form type as a service is a good practice and make it easily usable in | |||
| .. tip:: | ||
|
|
||
| Defining your form type as a service is a good practice and makes it easily usable in | ||
| your application : |
There was a problem hiding this comment.
you should remove the space before the colon
|
I like it, but I think it's too long for a book article. What about removing the code examples and only having the first paragraph and the last one (including the link)? |
|
Thank you for the review. I'll make the changes. Personnally I like to have example to know immediatety how to use that (and only click on the link if I want more information). I'm agree with the fact the book/form is quite long, but as a book entry, I think it should be complete. So, just tell me if I remove some text/code or not :) |
|
I'll let @weaverryan make the final discission ;-) |
Book/Form : Adding a new section about defining forms as service
|
Hi guys! First, thanks Greg for this nice entry. I noticed that we do talk about the Now, as Wouter mentioned, things are getting very busy in here. But, I think for now, we can continue adding things here. At some point, we'll break this into smaller pieces, and then we'll be more "choosy" about this chapter :). Thanks everyone! |
|
Thanks you Ryan! |