Skip to content

The instructions are incomplete. #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2013
Merged

The instructions are incomplete. #2675

merged 1 commit into from
Jun 30, 2013

Conversation

jsarracco
Copy link
Contributor

Added routes and doctrine commands

Added routes and doctrine commands
@J7mbo
Copy link
Contributor

J7mbo commented May 30, 2013

Note: Unless you're documenting a feature that's new to a specific version of Symfony (e.g. Symfony 2.2), all pull requests must be based off of the 2.1 branch, not the master or 2.2 branch.
From the docs README


create:
pattern: /create
defaults: { _controller: AcmeAccountBundle:Account:create }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

route definitions should also be added in XML and PHP format

weaverryan added a commit that referenced this pull request Jun 30, 2013
The instructions are incomplete.
@weaverryan weaverryan merged commit b0de5d8 into symfony:2.2 Jun 30, 2013
weaverryan added a commit that referenced this pull request Jun 30, 2013
1) Added XML and PHP routing
2) Removed database creation step and re-worded items
@weaverryan
Copy link
Member

Hi there!

I've merged in your pull request with minor changes at sha: e3147da. We certainly do like to include all of the instructions so people can get the examples working, so these are nice additions.

Thanks!

weaverryan added a commit that referenced this pull request Jun 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants