Added docs for enum nodes #2706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Jun 6, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes ( symfony/symfony#4420 ) |
| Applies to | 2.1+ |
| Fixed tickets | #2477 |
| ~~~~~~~~~~ | ||
|
|
||
| .. versionadded:: 2.1 | ||
| The enum node was new in 2.1 |
There was a problem hiding this comment.
Is the past tense form intended here? I don't think it's a good idea mixing present tense and past tense throughout the documentation
There was a problem hiding this comment.
I thought we always use the past tense for these messages
There was a problem hiding this comment.
I found only one match for past tense in components/stopwatch.rst
weaverryan
added a commit
that referenced
this pull request
Jun 30, 2013
|
Beautiful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.