[book] Avoid scrollbars in code examples #2749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $ php app/console doctrine:generate:entity --entity="AcmeStoreBundle:Product" --fields="name:string(255) price:float description:text" | ||
| $ php app/console doctrine:generate:entity \ | ||
| --entity="AcmeStoreBundle:Product" \ | ||
| --fields="name:string(255) price:float description:text" |
There was a problem hiding this comment.
for me, I think the example would be more readable if further lines are indented like this:
$ php app/console doctrine:generate:entity \
--entity="AcmeStoreBundle:Product" \
--fields="name:string(255) price:float description:text"
weaverryan
added a commit
that referenced
this pull request
Jun 30, 2013
[book] Avoid scrollbars in code examples
weaverryan
added a commit
that referenced
this pull request
Jun 30, 2013
This is technically correct, and prevents the scrollbar online, but I don't want to confuse any users with these
|
Hey Wouter! Very nice! You're absolutely correct with your use of Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one thing I'm not sure about and that thing are the wrapped commands:
I don't know if it is commonly known that the
\character can be used for multiline commands