Skip to content

Reference/forms/type/country : Minor bad copy/paste fix #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2013

Conversation

gregquat
Copy link
Contributor

@gregquat gregquat commented Jul 4, 2013

No description provided.

The country type defaults the ``choices`` option to the all locales.
It uses the default locale to determine the language.
The country type defaults the ``choices`` option to the whole list of countries.
It uses the default locale to determine which language to use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this true?

@gregquat
Copy link
Contributor Author

gregquat commented Jul 4, 2013

I do not understand. What is true? I suppose (because I've never used this type) that the returned list is the countries list and not the language list (the same sentence can be seen in the language type)
And for the second sentence, I just tried to clarify it. I don't know if the sence was "the default selected language in the list is the locale" or "the locale is used to translate the countries names".

As it's written above in the doc that the names are translated, I've chosen the second.

@wouterj
Copy link
Member

wouterj commented Jul 6, 2013

Sorry, I was a bit unclear. I did some research I it should be "the default locale is used to translate the countries names". The sentence is maybe still a bit unclear know...

@xabbuh
Copy link
Member

xabbuh commented Jul 6, 2013

👍

weaverryan added a commit that referenced this pull request Jul 18, 2013
Reference/forms/type/country : Minor bad copy/paste fix
@weaverryan weaverryan merged commit 143df02 into symfony:2.3 Jul 18, 2013
@weaverryan
Copy link
Member

Thanks Greg! Yes, a bad copy and paste for the 2.3 changes it seems - cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants