Skip to content

fix security context example code #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2013
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 20, 2013

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #2837

@wouterj
Copy link
Member

wouterj commented Jul 20, 2013

Could you please change the links in the note to absolute links?

@xabbuh
Copy link
Member Author

xabbuh commented Jul 21, 2013

Done. Is there any specific reason for using absolute links?

weaverryan added a commit that referenced this pull request Jul 28, 2013
fix security context example code
@weaverryan weaverryan merged commit 9328da9 into symfony:2.2 Jul 28, 2013
@weaverryan
Copy link
Member

Perfect PR - thanks @xabbuh!

@wouterj
Copy link
Member

wouterj commented Jul 29, 2013

To answer your question: Absolute links makes it possible to include the file in other places of the docs (had that problem with the cmf docs). But since that isn't the case with these documents, I think it's done for consistency (!) and properbly because fabien started doing that :)

@xabbuh xabbuh deleted the issue-2837 branch July 30, 2013 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants