Skip to content

fixing link to the translation domain section in cookbook article #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2013

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 22, 2013

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@wouterj
Copy link
Member

wouterj commented Jul 25, 2013

This needs to be fixed in #2545 Could you please confirm that and send a pr to that branch on my repo?

@xabbuh
Copy link
Member Author

xabbuh commented Jul 25, 2013

@wouterj, the Translation section in the "How to Override any Part of a Bundle" article is missing in your branch. Can you rebase it first?

weaverryan added a commit that referenced this pull request Jul 28, 2013
fixing link to the translation domain section in cookbook article
@weaverryan weaverryan merged commit aed1876 into symfony:2.2 Jul 28, 2013
@weaverryan
Copy link
Member

Great job! About #2545, we would need to add the new anchor into the translation doc. I'm not too worried about that, as it'll show up as a build error and we can fix it then.

@xabbuh xabbuh deleted the translation-domain-link branch July 30, 2013 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants