Skip to content

Add note about PHP 5.3 behaviour and proxies. #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Oct 10, 2013
Merged

Add note about PHP 5.3 behaviour and proxies. #3018

merged 2 commits into from Oct 10, 2013

Conversation

ghost
Copy link

@ghost ghost commented Sep 28, 2013

Q A
Doc fix? yes
New docs? no
Applies to all (or 2.1+)
Fixed tickets symfony/symfony#9119

@wouterj
Copy link
Member

wouterj commented Sep 28, 2013

2.1 is deprecated too, this should get merged in 2.2

@ghost
Copy link
Author

ghost commented Sep 28, 2013

It doesn't matter, this is a clarification about the feature so it should be added to 2.1.


Under PHP 5.3, you cannot proxy the session handler interface for native PHP handlers,
only user handlers so if you write proxies, be aware they will only work for user-land
session save handlers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd split this into two sentences (I also made some minor tweaks to the wording):

Until PHP 5.3, you cannot proxy the session handler interface for native PHP handlers, 
but only for custom handlers. Thus, if you write proxies, be aware that they will only work
for user-land session save handlers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's wrong. If you say "since 5.3" it means since 5.3.0 up to the current version (5.5.x). That is not the case. "Under PHP 5.3" means all version of PHP 5.3.x

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct. I meant until (I changed my suggestion). Maybe Before PHP 5.4 was even better.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until is still not accurate. Before PHP 5.4 or Under PHP 5.3 are the only two that convey the accuracy of what needs to be said. Before PHP 5.4 is best.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with Before PHP 5.4, but I dont understand why until is not correct. Under PHP 5.3 is giving me the feeling, that it was not possible in all PHP versions before PHP 5.3 and that is has been introduced in PHP 5.3.

weaverryan added a commit that referenced this pull request Oct 10, 2013
Add note about PHP 5.3 behaviour and proxies.
@weaverryan weaverryan merged commit b65456b into symfony:2.1 Oct 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants