Skip to content

[Security] Fix typo #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2013
Merged

[Security] Fix typo #3089

merged 1 commit into from
Nov 3, 2013

Conversation

bicpi
Copy link
Contributor

@bicpi bicpi commented Oct 23, 2013

Maybe the "logout" key could be even omitted here because the section is not about the logout and the real key to configure is not "logout" but "path" under the key "logout".

Shouldn't this notice be removed in the 2.3 branch since Symfony 2.1 has reached end of maintenance?

weaverryan added a commit that referenced this pull request Nov 3, 2013
@weaverryan weaverryan merged commit 23d6c51 into symfony:2.2 Nov 3, 2013
@weaverryan
Copy link
Member

Hey Philipp!

Good change. I agree with your note about not needing logout here (since we talk about that later), so I've removed it at sha: dbe4591.

About the end of maintenance, what happens is that when 2.1 reached end of maintenance (for our purposes, we said that it happened right after 2.3 was released), we removed the note versionadded tags from the next release (i.e. master branch). See http://symfony.com/doc/current/contributing/documentation/overview.html#when-a-release-reaches-end-of-maintenance. So, the note is gone on the master branch :).

Thanks!

@bicpi
Copy link
Contributor Author

bicpi commented Nov 4, 2013

Thanks, read that note about the version boxes again, now it's clear to me.

@bicpi bicpi deleted the fix_typo branch January 5, 2014 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants