Skip to content

[Components] Reorder installation instructions #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2013
Merged

[Components] Reorder installation instructions #3103

merged 2 commits into from
Nov 3, 2013

Conversation

bicpi
Copy link
Contributor

@bicpi bicpi commented Oct 26, 2013

Q A
Doc fix? yes
New docs? -
Applies to -
Fixed tickets #3102

@xabbuh
Copy link
Member

xabbuh commented Oct 27, 2013

👍 But be aware that you also need to swap the comma (used for all but the last item of a list) and the full stop (used for the last item).

@bicpi
Copy link
Contributor Author

bicpi commented Oct 27, 2013

@xabbuh Wasn't aware of this, fixed it, thank you. Do you think it would be worth to mention this convention in the "Contributing" section?

@wouterj
Copy link
Member

wouterj commented Oct 27, 2013

No, this standard doesn't include all lists.

weaverryan added a commit that referenced this pull request Nov 3, 2013
[Components] Reorder installation instructions
@weaverryan weaverryan merged commit 6c4491e into symfony:2.2 Nov 3, 2013
@cordoval
Copy link
Contributor

cordoval commented Nov 4, 2013

@wouterj if it does not include all lists, then is this an isolated use case? 👶 just wanted to have this clear

@bicpi
Copy link
Contributor Author

bicpi commented Nov 4, 2013

I've found lot of other lists where this convention is not used.

@wouterj
Copy link
Member

wouterj commented Nov 4, 2013

@cordoval mainly if you use a list to list methods, features, things, etc. you do not use thee semi colon. If the list items are complete sentences or if they are ordered, you use the semi colon.

@bicpi bicpi deleted the reorder_installation_instructions branch November 4, 2013 07:51
@bicpi bicpi restored the reorder_installation_instructions branch November 4, 2013 07:51
@bicpi bicpi deleted the reorder_installation_instructions branch January 5, 2014 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants