Fix hostname matching articles #3125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| projects_homepage: | ||
| path: / | ||
| host: {project_name}.example.com |
There was a problem hiding this comment.
you need to quote this value, because { would start a YAML hash here, not be parsed as the first char of a string value, and this could be a parse error (because of the end of the string)
weaverryan
added a commit
that referenced
this pull request
Nov 3, 2013
Fix hostname matching articles
|
This is awesome - great work Wouter! |
|
You're welcome :) It's one of my first text-adding PRs without a 'fix' commit from you I think! I'm slowly learning english... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The articles were talking about host regexes, while they are no regex but simple strings.
This PR fixes that. It also includes more information how to match multiple hostnames (which
is a common use case for regexes).