I'm against updating it to 5.3.3. From the readme:

Be warned that PHP versions before 5.3.8 are known to be buggy and might not work for you:

• before PHP 5.3.4, if you get "Notice: Trying to get property of non-object", you've hit a known PHP bug (see https://bugs.php.net/bug.php?id=52083 and https://bugs.php.net/bug.php?id=50027);
• before PHP 5.3.8, if you get an error involving annotations, you've hit a known PHP bug (see https://bugs.php.net/bug.php?id=55156).
• PHP 5.3.16 has a major bug in the Reflection subsystem and is not suitable to run Symfony2 (https://bugs.php.net/bug.php?id=62715)

However, we can maybe rephrase this a bit to make it clear that you can also use it with 5.3.3 and then link to this section in the readme. Could you please do that?

@wouterj Thanks for the input, that's what I thought too. Is it better now ? If yes, I'll apply it to the other translations as well (at least for French, and ask an Italian speaker for some help :)).

I don't know the syntax enough to add a link on "highly recommended" to the exact section of the README. Could you help on that ?

+1 for "5.3 with 5.8 warning".
I think also this page should be adapted http://symfony.com/doc/current/reference/requirements.html

@gnutix I think it's better to put the link + caution in the reference/requirements article. This keeps the book article short and not full of lots of side information.

I think the best way is to add a caution directive at the bottom of the 'Required' section on that page. It'll look like:

.. caution::

    Be aware that Symfony2 has some known limitations when using PHP 5.3.8
    or below. For more information see the `Requirements section of the readme`_

.. _`Requirements section of the readme`: https://github.com/symfony/symfony#requirements

The last line should be put on the bottom of the file.

@wouterj done. I'm hesitating if that "caution" block should be on the bottom on the requirements page or bottom of the requirements section. Think it's more visible on the section, as PHP is listed in there. WDYT?

@gnutix the caution block should be in the section. The last line of my snippet is only telling sphinx to which url the text between backticks in the block should link. It is not displayed. This information should be placed at the bottom of the file.

@wouterj Thanks for the tip! Fixed it. (I should really learn that syntax...)

Hi guys!

I really like what you guys have done here - it's a nice warning and also removes duplication in general. So, great work!

I've patched this into the 2.2. branch at:

• sha: 1cc6a05
• sha: b1e6a37
• sha: d9b2cc0
• sha: 9904646
• sha: cab585e

and small tweaks at sha: f14ef95

Thanks!

Thanks Ryan :)

@weaverryan looks like only 2.2 branch was updated. What about master and 2.3?

@garak 2.2 is merged into 2.3 on a regular basis (and 2.3 into master). So 2.3 will be updated on the next merge (Ryan generally does such a merge after merging a bunch of PRs)

thanks for clarification stof!

So, the final wording suggests that PHP 5.3.8 is not good, while Symfony2 README states that it is.
Maybe "versions of PHP before 5.3.8" would be better than "PHP 5.3.8 or below"

@garak Argh, nice catch ! Should be when using a PHP version lower than 5.3.8. Fixed in french PR.
@weaverryan Should we open a new one for English ?

If you look at the bugs, you see a bug for 5.3.8, so that version is also not good

@wouterj https://github.com/symfony/symfony/blob/master/README.md

Requirements

Symfony2 is only supported on PHP 5.3.3 and up.

Be warned that PHP versions before 5.3.8 are known to be buggy and might not work for you:

* before PHP 5.3.4, if you get "Notice: Trying to get property of non-object", you've hit a known PHP bug (see https://bugs.php.net/bug.php?id=52083 and https://bugs.php.net/bug.php?id=50027);

* before PHP 5.3.8, if you get an error involving annotations, you've hit a known PHP bug (see https://bugs.php.net/bug.php?id=55156).

* PHP 5.3.16 has a major bug in the Reflection subsystem and is not suitable to run Symfony2 (https://bugs.php.net/bug.php?id=62715)

So it's buggy with PHP_VERSION < 5.3.8 || PHP_VERSION == 5.3.16

A, "before"... I think I misread it, so yeah could you please open a PR to fix the caution?

@wouterj Done #3223