[Cookbook][Configuration] Fix front controller sample codes #3245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Dec 1, 2013
[Cookbook][Configuration] Fix front controller sample codes
weaverryan
added a commit
that referenced
this pull request
Dec 1, 2013
This removes code that could easily become out of date again. Also, I don't think it was necessary - we want to focus them on only one line anyways.
|
Hey Philipp! Ah, thanks for catching this out of date code! I read through the section, and I don't think that the code is really necessary at all. We're focusing them on the Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prodandbenchmarkfront controller were still using 2.0 code.benchmarkfront controller it says Copy theweb/app.php... but then the code differs from theapp.phpnot only in the enironment key.I thought about removing the comments about caching to keep the code short. But then you would maybe wonder about the
$loadervariable declaration. Morover, the text says If you open up one of these files ..., so maybe it's better to show the file as is when you open it.