-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
improve the serialization of custom user models #3307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xabbuh
commented
Dec 9, 2013
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | all |
Fixed tickets | #3165 |
|
||
When your ``User`` class implements the | ||
:class:`Symfony\\Component\\Security\\Core\\User\\EquatableInterface` | ||
interface, it is sufficient to just serialize the ``id`` property in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When implementing EquatableInterface, you determine yourself which peoperties you use to compare the objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the wording. What do you think?
+1 (btw, not to stop you contributing, but this weekend we have a sprint day, could you please leave some easy picks open for that day? 😺 ) |
@wouterj is all good, we are already on the hacking day 👶 where everything is possible |
Oh, did I miss something? Thought that was more of a code hacking day. |
you are good, is both |
Xabbuh, yes you missed something. It's a hackday for many symfony related topics. @cordoval I know it's not a big deal, but we don't have that many easy issues. |
that means only one thing, we have to adapt, also we should closely work with the teams, that should help enforce things. Perfect! Is going as planned, as the goal will be achieved no matter what. |
@xabbuh don't worry :) but yeah that's perfect, however I already started with the validator docs. (did not came that far) |
improve the serialization of custom user models
Hey guys! I also added a note related to AdvancedUserInterface at sha: 7325ec5. Hopefully that helps - this is a complicated issue to describe and debug, unfortunately. And if you get the implementation right, it's not really important that you understand it. Let me know if you have any further suggestions. Thanks! |
(cherry picked from commit 7325ec5)