Skip to content

improve the serialization of custom user models #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2013

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 9, 2013

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #3165


When your ``User`` class implements the
:class:`Symfony\\Component\\Security\\Core\\User\\EquatableInterface`
interface, it is sufficient to just serialize the ``id`` property in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When implementing EquatableInterface, you determine yourself which peoperties you use to compare the objects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the wording. What do you think?

@wouterj
Copy link
Member

wouterj commented Dec 9, 2013

+1 (btw, not to stop you contributing, but this weekend we have a sprint day, could you please leave some easy picks open for that day? 😺 )

@cordoval
Copy link
Contributor

cordoval commented Dec 9, 2013

@wouterj is all good, we are already on the hacking day 👶 where everything is possible

@xabbuh
Copy link
Member Author

xabbuh commented Dec 9, 2013

Oh, did I miss something? Thought that was more of a code hacking day.

@cordoval
Copy link
Contributor

cordoval commented Dec 9, 2013

you are good, is both

@wouterj
Copy link
Member

wouterj commented Dec 9, 2013

Xabbuh, yes you missed something. It's a hackday for many symfony related topics.

@cordoval I know it's not a big deal, but we don't have that many easy issues.

@xabbuh
Copy link
Member Author

xabbuh commented Dec 9, 2013

Sorry, that wasn't my intention. I will then focus on #954 and #958 if you are fine with that.

@cordoval
Copy link
Contributor

cordoval commented Dec 9, 2013

that means only one thing, we have to adapt, also we should closely work with the teams, that should help enforce things. Perfect! Is going as planned, as the goal will be achieved no matter what.

@wouterj
Copy link
Member

wouterj commented Dec 9, 2013

@xabbuh don't worry :) but yeah that's perfect, however I already started with the validator docs. (did not came that far)

weaverryan added a commit that referenced this pull request Dec 19, 2013
improve the serialization of custom user models
@weaverryan weaverryan merged commit 962e204 into symfony:2.3 Dec 19, 2013
@weaverryan
Copy link
Member

Hey guys!

I also added a note related to AdvancedUserInterface at sha: 7325ec5. Hopefully that helps - this is a complicated issue to describe and debug, unfortunately. And if you get the implementation right, it's not really important that you understand it.

Let me know if you have any further suggestions.

Thanks!

@xabbuh xabbuh deleted the issue-3165 branch December 19, 2013 09:32
weaverryan added a commit that referenced this pull request Dec 19, 2013
weaverryan added a commit that referenced this pull request Jan 2, 2014
weaverryan added a commit that referenced this pull request Jan 2, 2014
(cherry picked from commit 38612bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants