Note was added to preferred_choices option of entity field type #3316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note was added to clarify expectations of this option
|
Can you include the pull request template? |
| @@ -182,6 +182,10 @@ These options inherit from the :doc:`choice </reference/forms/types/choice>` typ | |||
|
|
|||
| .. include:: /reference/forms/types/options/preferred_choices.rst.inc | |||
|
|
|||
| .. note:: | |||
|
|
|||
| This option expects for array of objects unlike choice field that requires an array of keys | |||
There was a problem hiding this comment.
This option expects an array of objects unlike the choice field that requires an array of keys.
|
@xabbuh I am not sure I understand what is 'pull request template'? |
|
Have a look at the Pull Request Format. Hope this helps you. :) |
|
@xabbuh added, thank you. |
weaverryan
added a commit
that referenced
this pull request
Dec 19, 2013
Note was added to preferred_choices option of entity field type
weaverryan
added a commit
that referenced
this pull request
Dec 19, 2013
|
Hi Michael! Ah, this is an excellent note - thanks so much for adding it! Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note was added to clarify that 'preferred_choices' option expects for array of objects but not for array of keys as default choice field type