[WIP] [security] adding a tip about supported algorithm for 'hash' function #3325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianLB
commented
Dec 14, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.2+ |
| Fixed tickets | #3158 |
|
Could you please add the PR format to your PR description? |
| @@ -1358,6 +1358,10 @@ the password is simply run through the ``sha1`` algorithm one time and without | |||
| any extra encoding. You can now calculate the hashed password either programmatically | |||
| (e.g. ``hash('sha1', 'ryanpass')``) or via some online tool like `functions-online.com`_ | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| Supported algorithms for this method depend on your PHP version. Full list is available calling the PHP method ``hash_algos()``. | |||
There was a problem hiding this comment.
you should break a line after the first word that crosses the 72th character.
There was a problem hiding this comment.
And what about "A full list is available [...]"?
There was a problem hiding this comment.
and, as last, you can use a PHP.net link:
:phpfunction:`hash_algos`|
|
|
Thx for feedback. Fixed. |
weaverryan
added a commit
that referenced
this pull request
Dec 26, 2013
[WIP] [security] adding a tip about supported algorithm for 'hash' function
|
Nice work Florian! Very nice to meet you at the conference! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.