[Draft] Added detailed BC promise text #3438
Conversation
| Remove default value of a parameter No No | ||
| Add type hint to a parameter No No | ||
| Remove type hint of a parameter Yes [1]_ No | ||
| Change return type Yes [1]_ No |
There was a problem hiding this comment.
changing the return type should be allowed only for compatible return values, to avoid breaking calling code, otherwise it is not safe to use anymore
There was a problem hiding this comment.
Yes, I initially had a footnote for that there, but then you need to define which return values are "compatible". I couldn't really find a useful definition here.
There was a problem hiding this comment.
if changing the return type is allowed, you can basically allow everything else as well. I would rather get a fatal error that a method signature is wrong, than having some nasty bugs because of changed return type, like array[0] is suddenly string[0].
|
fyi, this needs a rebase |
|
Replaced by #3439 (correctly rebased onto 2.1 now). |
I created a detailed text about which parts of the Symfony code are covered by our BC promise. The goals are to:
I'll continue working on the individual rules of allowed changes. Nevertheless, let me hear your feedback.