Skip to content

[WIP][Reference][Form Types] Add missing options for "form" type #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2014
Merged

[WIP][Reference][Form Types] Add missing options for "form" type #3449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd6c0a7
[Reference][Form Types] Add missing options for "form" type
bicpi Jan 9, 2014
d066f4d
Improvements after review
bicpi Jan 11, 2014
a42e971
Improve wording
bicpi Jan 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Reference][Form Types] Add missing options for "form" type
  • Loading branch information
@bicpi
bicpi committed Jan 23, 2014
commit dd6c0a765cc7ab3a93363f48ad59fac67bee82cb
5 changes: 5 additions & 0 deletions reference/forms/types/form.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,8 @@ on all fields.

.. include:: /reference/forms/types/options/invalid_message_parameters.rst.inc

.. include:: /reference/forms/types/options/extra_fields_message.rst.inc

.. include:: /reference/forms/types/options/post_max_size_message.rst.inc

.. include:: /reference/forms/types/options/pattern.rst.inc
9 changes: 9 additions & 0 deletions reference/forms/types/options/extra_fields_message.rst.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
extra_fields_message
~~~~~~~~~~~~~~~~~~~~

**type**: ``string`` **default**: ``This form should not contain extra fields.``

This is the validation error message that's used if the submitted form data
contains one or more fields that are not part of the form definition. The
placeholder ``{{ extra_fields }}`` can be used to display a comma separated
list of the submitted extra field names.
16 changes: 16 additions & 0 deletions reference/forms/types/options/pattern.rst.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
pattern
~~~~~~~

**type**: ``string`` **default**: ``null``

This option adds a ``pattern`` attribute to restrict the field input by a
regular expression.

.. caution:

This validation is client-side only.

.. note:

When using validation constraints, this option is set automatically
for some constraints to match the server-side validation.
12 changes: 12 additions & 0 deletions reference/forms/types/options/post_max_size_message.rst.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
post_max_size_message
~~~~~~~~~~~~~~~~~~~~~

**type**: ``string`` **default**: ``The uploaded file was too large. Please try to upload a smaller file.``

This is the validation error message that's used if submitted POST form data
exceeds php.ini's ``post_max_size``. The ``{{ max }}`` placeholder can be used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we use literals for php.ini?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use literals for files names, so imo we should use them too for php.ini.

to display the allowed size.

.. note:

Validating the ``post_max_size`` only happens on the root form.