clarify that optional placeholders can only be used at the end of a rout... #3452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| that everything after the first optional placeholder can be omitted in | ||
| a request. Otherwise your route will never match if the optional placeholder | ||
| is not given. For example, in the example above it was not possible to | ||
| move the ``{page}}`` placeholder before the ``/blog`` part of the route |
There was a problem hiding this comment.
and maybe using {_locale} is a more real use-case.
There was a problem hiding this comment.
You're right. But I'd then change the whole example. Otherwise, the example in the note would be rather unrelated to the example described in this chapter. What do you think?
|
👍 |
| a request. Otherwise your route will never match if the optional placeholder | ||
| is not given. For example, in the example above it was not possible to | ||
| move the ``{page}`` placeholder before the ``/blog`` part of the route | ||
| path. |
There was a problem hiding this comment.
I like this, but maybe we can make it shorter by having more examples. Like:
Of course, you can have more than one optional placeholder (e.g. ``/blog/{slug}/{page}``),
but everything after an optional placeholder must be optional. For example, ``/{{page}}/blog``
is a valid path, but ``page`` will always be required (i.e. simply ``/blog`` will not match
this route).
What do you think? It's kind of a trick explanation, that needs to be done quickly.
There was a problem hiding this comment.
+1 for your proposal (except that /{{page}}/blog is Twig syntax, it should be /{page}/blog)
|
@xabbuh can you rebase please? |
|
@weaverryan done |
weaverryan
added a commit
that referenced
this pull request
Feb 1, 2014
clarify that optional placeholders can only be used at the end of a rout...
|
Thanks @xabbuh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...e path