Skip to content

document the ability to configure more than one mailer at the same time #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2014
Merged

document the ability to configure more than one mailer at the same time #3464

merged 1 commit into from
Feb 1, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 11, 2014

Q A
Doc fix? no
New docs? yes (symfony/swiftmailer-bundle#34)
Applies to all
Fixed tickets #3440

@Koc
Copy link
Contributor

Koc commented Jan 11, 2014

Please add note about retriving concrete mailer from container.

@xabbuh
Copy link
Member Author

xabbuh commented Jan 11, 2014

Thanks for your feedback @Koc. I added a paragraph demonstrating this.

@weaverryan
Copy link
Member

@xabbuh This is absolutely great work. My only thought is if we can save on some duplication by not repeating the options under the second mailer (just show have the second mailer key, then ... under it - or even # all the same potential options ...). What do you think?

@xabbuh
Copy link
Member Author

xabbuh commented Jan 21, 2014

@weaverryan that's a good point. I shortened the examples. What do you think? I'm not so glad with the XML example but shorten them is not really possible without destroying the syntax highlighting.

bicpi
bicpi reviewed Jan 22, 2014
View reviewed changes
reference/configuration/swiftmailer.rst
// ...

// returns the primary mailer
$container->get('swiftmailer.mailer.primary_mailer');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first_mailer

weaverryan added a commit that referenced this pull request Feb 1, 2014
@weaverryan
Merge pull request #3464 from xabbuh/issue-3440
b804087 
document the ability to configure more than one mailer at the same time
@weaverryan weaverryan merged commit b804087 into symfony:2.3 Feb 1, 2014
@weaverryan
Copy link
Member

@xabbuh I think it's great. True, the XML still has quite a bit of code in it, but it's mostly the boilerplate elements/namespaces that won't change anyways.

Great job on this!

@xabbuh xabbuh deleted the issue-3440 branch February 1, 2014 18:25
@wouterj
Copy link
Member

wouterj commented Feb 1, 2014

@weaverryan you forgot to use gh here ;)

@weaverryan
Copy link
Member

Haha, yea, I got too excited :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @Koc @weaverryan @wouterj @bicpi