[Cookbook][Assetic] Fix "javascripts" tag name typo #3485
Conversation
|
+1 to move the note to a note directive after the example, showing the javascritps block. |
|
@wouterj I've moved it to a note and likewise for |
|
@bicpi you should also add the PHP format. (see the templating component docs for a PHP example of blocks) And -1 for Standard Distribution to Standard Edition, it's the Standard Distribution of Symfony, which is called the Standard Edition. |
|
@wouterj I'm a bit confused about the Distribution/Edition thing now. I thought the only official Symfony Distribution is the Standard Edition (on the Download page) and the note talks about the Twig blocks in this Standard Edition. I wanted to include the PHP example, but the Standard Edition does not provide a base PHP template - in this case it would not make sense to add PHP samples. |
|
I really like the change - tI've seen the javascripts block versus tag confuse many people - I think you handled it very nicely. And I agree - since there is no PHP base template, Ithe note with just Twig makes sense to me :). Cheers! |
This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Assetic] Fix "javascripts" tag name typo | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Maybe the following note *This will most commonly live in the ``javascripts`` block...* is a bit confusing because the example does not show this Twig block and it has the same name as the Twig tag... The note could either be removed or I could add the `javascripts` Twig block to clarify? Commits ------- f9a287b Move note about "javascripts" and "stylesheets" blocks to separate note blocks cf8064d [Cookbook][Assetic] Fix "javascripts" tag name typo
Maybe the following note This will most commonly live in the
javascriptsblock... is a bit confusing because the example does not show this Twig block and it has the same name as the Twig tag... The note could either be removed or I could add thejavascriptsTwig block to clarify?