[Reference][Forms] remove the label_attr option which is not available in the button type #3651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 makes perfect sense! |
weaverryan
added a commit
that referenced
this pull request
Mar 19, 2014
…not available in the button type (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Reference][Forms] remove the label_attr option which is not available in the button type | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | The ``label_attr`` is neither defined in the ``ButtonType`` class nor in the ``BaseType`` class, but in the ``FormType`` class instead. Thus, it can't be used for the ``button`` type. Commits ------- 5bafc3c remove the label_attr option which is not available in the button type
|
The label_attr is still appearing in the documentation for the button type: http://symfony.com/fr/doc/current/reference/forms/types/button.html |
|
@happypoulp You are looking at the French translation which has its own repository. Seems not to be up-to-date. |
|
@happypoulp you should report it to https://github.com/symfony-fr/symfony-docs-fr/ And I think the french translator will be even happier if you submit a PR to that repo, removing the same things as @xabbuh did here. |
|
Good to know, I'll do that, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
label_attris neither defined in theButtonTypeclass nor in theBaseTypeclass, but in theFormTypeclass instead. Thus, it can't be used for thebuttontype.