Skip to content

[Cookbook][Test] fix sample code #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2014
Merged

[Cookbook][Test] fix sample code #3665

merged 1 commit into from
Mar 12, 2014

Conversation

inelgnu
Copy link
Contributor

@inelgnu inelgnu commented Mar 12, 2014

Q A
Doc fix? yes
New docs? no
Applies to all

@inelgnu inelgnu mentioned this pull request Mar 12, 2014
Closed
@inelgnu inelgnu closed this Mar 12, 2014
@inelgnu inelgnu deleted the 2.3 branch March 12, 2014 09:41
@inelgnu inelgnu restored the 2.3 branch March 12, 2014 09:41
@inelgnu inelgnu reopened this Mar 12, 2014
@wouterj
Copy link
Member

wouterj commented Mar 12, 2014

Thank you for your work. 2 tips from me (for the next time):

  • We can easily cherry pick commits into other branches, you don't need to create a new PR for that. @bicpi just told it you, so you do it right the next time :)
  • Always create a new branch when editing something (when editing a file from this repo of a specific branch, you'll always create a patch-N branch in your own fork). When doing this, you can create multiple PRs at the same time.

@weaverryan
Copy link
Member

Great fix - thanks @inalgnu!

weaverryan added a commit that referenced this pull request Mar 12, 2014
@weaverryan
bug #3665 [Cookbook][Test] fix sample code (inalgnu)
de0a5e1 
This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Test] fix sample code

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all

Commits
-------

370d614 [Cookbook][Test]fix sample code
@weaverryan weaverryan merged commit 370d614 into symfony:2.3 Mar 12, 2014
@inelgnu inelgnu deleted the 2.3 branch March 12, 2014 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inelgnu @wouterj @weaverryan