Tweak to Absolute URL generation #3693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so we have the controller/PHP version and template version in the same spot. See #3573 I also made a few other tweaks, including using generateUrl (like we did earlier) to generate the absolute URL, not going through the router service directly.
Closed
| a controller, simply pass ``true`` to the third argument of the ``generateUrl()`` | ||
| method:: | ||
|
|
||
| $this->getgenerateUrl('blog_show', array('slug' => 'my-blog-post'), true); |
There was a problem hiding this comment.
Remove the get from getgenerateUrl
There was a problem hiding this comment.
hmm, are you sure? Just kidding - thanks for catching that ;)
|
👍 |
|
Thanks for the sanity check as always @xabbuh :) |
weaverryan
added a commit
that referenced
this pull request
Mar 19, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Tweak to Absolute URL generation | Q | A | |----------------|------| | Doc fix | yes | | New docs | no | | Applies to | 2.3 | | Fixed tickets | #3573 | This updates how we describe URL generation. After #3573, it occurs to me that if you're looking here for a reference, you'll look for the first spot where absolute URLs are discussed and try to use it. So why not put the controller/PHP version and template version of doing this in the same spot. Cheers! Commits ------- 007a54f Fixing typo thanks to @xabbuh 873706c Moved the section about generating absolute URLs down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates how we describe URL generation. After #3573, it occurs to me that if you're looking here for a reference, you'll look for the first spot where absolute URLs are discussed and try to use it. So why not put the controller/PHP version and template version of doing this in the same spot.
Cheers!