Skip to content

fix origin of AcmeDemoBundle #3951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

hice3000
Copy link
Contributor

No description provided.

@@ -14,8 +14,7 @@ Automatically Registering Commands
To make the console commands available automatically with Symfony2, create a
``Command`` directory inside your bundle and create a PHP file suffixed with
``Command.php`` for each command that you want to provide. For example, if you
want to extend the AcmeDemoBundle (available in the Symfony Standard
Edition) to greet you from the command line, create ``GreetCommand.php`` and
want to extend the AcmeDemoBundle (available in the SensioDistributionBundle) to greet you from the command line, create ``GreetCommand.php`` and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add some line breaks here after the 72nd character :).

Check out the second bullet point here: http://symfony.com/doc/current/contributing/documentation/standards.html#sphinx

Can you make that change? Thanks!

@wouterj
Copy link
Member

wouterj commented Jun 20, 2014

I'm not sure if I like this change. It still lives in the AcmeDemoBundle, but only if you installed it. SensioDistributionBundle is just because we need to save the skeleton files somewhere, it is not available in there only its skeleton.

On the other hand, "available in the Symfony Standard Edition" is maybe to short, since it is not always included there anymore.

@weaverryan
Copy link
Member

@wouterj I kind of agree, I'm mixed on this. It goes back your symfony/symfony#11165 - it causes some confusion. Though honestly, this entry doesn't even need to be using AcmeDemoBundle - we're just saying "Suppose there is a bundle called AcmeDemoBundle in your system, ..."

@hice3000
Copy link
Contributor Author

@wouterj @weaverryan How about (installed with SensioDistributionBundle, which is required by the Symfony Standard Edition by default) ?

@wouterj
Copy link
Member

wouterj commented Jun 20, 2014

I think we should just remove the whole thing inside the parenthesis.

Something like

To make the console commands available automatically with Symfony2, create a
``Command`` directory inside your bundle and create a PHP file suffixed with
``Command.php`` for each command that you want to provide. For example, if you
--- want to extend the AcmeDemoBundle (available in the Symfony Standard
--- Edition) to greet you from the command line, create ``GreetCommand.php`` and
+++ want to create a command which greets you, create a ``GreetCommand.php`` and
add the following to it:

I fixed a line break, too.
@hice3000
Copy link
Contributor Author

@wouterj I agree, commited this.

@weaverryan
Copy link
Member

I like it! Thanks a lot Malte!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants