-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Component][Forms] add missing features introduced in 2.3 #4085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@xabbuh Thanks for opening this. We need to keep track of what we do and don't have, and where. for example:
It's difficult because the form component has a significant amount of duplication, in part because we thought that we might try to make it work for both the component and framework all in one page (but I don't think that makes sense anymore). Ideally, I'd like to find a way to duplicate less. Let me know what you think! |
@weaverryan I absolutely agree with you when talking about duplicated documentation. My suggestion is, to first complete the documentation with this pull request (so that all the things you mentioned have been covered) and afterwards discuss how to deal with duplicated documentation separately (I opened #4100 to for this). What do you think? |
Yep, let's do that. You already have #4100 opened to track the duplication, so we can finish this PR, which will make sure that everything is covered and accomplished. 👍 |
Alright, I think I can manage to complete this til the end of the week. |
When it comes to duplicated documentation, we have to talk about
“Rendering a Form in a Template” directly links to the appropriate section in the book chapter. |
For |
I think the features you can use with buttons are already documented in the book: What do you think? Should we duplicate or move parts of this to the component section? |
|
||
By default, a form is submitted to the same URI that rendered the form with | ||
an HTTP POST request. This behavior can be changed using the :ref:`form-option-action` | ||
and :ref:`form-option-method` options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add one small detail here: the method
option is also used by handleRequest
to know if the form data should be processed.
@xabbuh I agree with you! So, I think this PR is ready, except for one small comment I just left. Thanks! |
These features are: * Use the submit() (instead of bind()) method to manually submit a form. * The ability to change a form's action and method.
@weaverryan I added a small note on it. |
Very-nicely written note. cheers Christian! |
….3 (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Component][Forms] add missing features introduced in 2.3 | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#6522) | Applies to | all | Fixed tickets | #2969 - [x] use ``submit()`` instead of ``bind()`` to manually submit a form - [x] configure method and action of a form - [ ] ~~render a form's start and its end separately~~ (see [the comment](#4085 (comment))) - [ ] configure buttons Commits ------- 33f6422 [Forms] add missing features being new in 2.3
submit()
instead ofbind()
to manually submit a formrender a form's start and its end separately(see the comment)configure buttons(see this comment)