Skip to content

support Varnish in configuration blocks #4287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2014
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 3, 2014

To be able to use them, fabpot/sphinx-php#20 has to be merged first. After that, the submodule reference has to be updated as well with this pull request.

@dbu @thierrymarianne Is Ruby the language to choose to get proper syntax highlighting?

@dbu
Copy link
Contributor

dbu commented Oct 5, 2014

i have seen people using C for syntax highlighting. given how primitive VCL is in terms of constructs, i guess there won't be much difference between ruby and C. both will have occasional random things highlight (not too likely) and both won't highlight the built-in constructs and system method names of vcl. lets go with ruby as you say it looks ok.

@stof
Copy link
Member

stof commented Oct 5, 2014

if you want to have better highlighting in the future, it could be possible to submit a PR to Pygments adding a new highlighter. @javiereguiluz did it for Twig.

@wouterj
Copy link
Member

wouterj commented Oct 11, 2014

Thanks Christian.

@wouterj wouterj merged commit f2bf980 into symfony:2.3 Oct 11, 2014
wouterj added a commit that referenced this pull request Oct 11, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

support Varnish in configuration blocks

To be able to use them, fabpot/sphinx-php#20 has to be merged first. After that, the submodule reference has to be updated as well with this pull request.

@dbu @thierrymarianne Is Ruby the language to choose to get proper syntax highlighting?

Commits
-------

f2bf980 support Varnish in configuration blocks
@xabbuh xabbuh deleted the varnish-versions branch October 11, 2014 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants