[WIP]Add browserkit component documentation #4310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 2.3 branch. Discussion ---------- Improve readability | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Commits ------- a715baf Improve readability
| @@ -0,0 +1,18 @@ | |||
| .. index:: | |||
| single: Yaml | |||
| single: Components; Yaml | |||
There was a problem hiding this comment.
These should be changed to BrowserKit. ;)
|
I whould change "Browser Kit" to "BrowserKit" everywhere. However, that's a nice start. I would now add some description on how to use the component after the installation instructions. |
| @@ -125,7 +125,8 @@ event listeners, you can learn more about them at :doc:`/cookbook/service_contai | |||
| $controller = $event->getController(); | |||
|
|
|||
| /* | |||
| * $controller passed can be either a class or a Closure. This is not usual in Symfony but it may happen. | |||
| * $controller passed can be either a class or a Closure. | |||
| * This is not usual in Symfony but it may happen. | |||
There was a problem hiding this comment.
it looks like your PR is not based on the upstream branch
|
|
||
| The Browser Kit component simulates the behavior of a web browser. | ||
|
|
||
| The Browser Kit component allows you to make web request, click on links and submit forms. |
There was a problem hiding this comment.
web requests or make a web request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on documentation for the browser kit. Fixes #954