[Validator] Updated documentation of URL validator #4631
Conversation
23980b5 to
11d813e
Compare
|
👍 for checkDNS, |
| @@ -8,6 +8,7 @@ Validates that a value is a valid URL string. | |||
| +----------------+---------------------------------------------------------------------+ | |||
| | Options | - `message`_ | | |||
| | | - `protocols`_ | | |||
| | | _ `checkDNS`_ | |||
There was a problem hiding this comment.
This line is missing the final pipe character.
|
And I also would not use the option in the first examples, but explain it in its own section (that you already added) instead. |
|
|
||
| **type**: ``Boolean`` **default**: ``false`` | ||
|
|
||
| If true, then the checkdnsrr PHP function will be used to check the validity |
There was a problem hiding this comment.
you can do :phpfunction:checkdnsrr`` to link to the php.net page.
Updated the documentation regarding the Pull Request on Symfony : symfony/symfony#12956
| @@ -8,6 +8,7 @@ Validates that a value is a valid URL string. | |||
| +----------------+---------------------------------------------------------------------+ | |||
| | Options | - `message`_ | | |||
| | | - `protocols`_ | | |||
| | | _ `checkDNS`_ | | |||
There was a problem hiding this comment.
The underscore before "checkDNS" should be a dash.
|
I agree with @xabbuh: the first examples should not use the |
…r (saro0h) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Validator] Added checkDNS option on URL validator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10088 | License | MIT | Doc PR | symfony/symfony-docs#4631 Commits ------- ad2f906 [Validator] Added a check DNS option on URL validator
…r (saro0h) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Validator] Added checkDNS option on URL validator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10088 | License | MIT | Doc PR | symfony/symfony-docs#4631 Commits ------- ad2f906 [Validator] Added a check DNS option on URL validator
|
I wish you a happy new year @saro0h. Can you update here given that the code pull request was merged? |
| @@ -26,6 +27,9 @@ Basic Usage | |||
| properties: | |||
| bioUrl: | |||
| - Url: ~ | |||
| message: The url "{{ value }}" is not a valid url. | |||
| protocols: [http, https] | |||
| checkDNS: true | |||
There was a problem hiding this comment.
would prefer if we set this to false because this is the default value.
|
@saro0h Can you update your pull request? |
…r (saro0h) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Validator] Added checkDNS option on URL validator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10088 | License | MIT | Doc PR | symfony/symfony-docs#4631 Commits ------- ad2f906 [Validator] Added a check DNS option on URL validator
|
Hi @saro0h! Upcoming Saturday, we'll be hosting a doc sprint day. We would like to finish as much PRs as possible during/before that day. Maybe you can join or, if you agree, we can put it on a list so others can work on it. |
Updated the documentation regarding the Pull Request on Symfony : symfony/symfony#12956