Update by_reference.rst.inc #4639

docteurklein · 2014-12-12T17:50:59Z

No description provided.

xabbuh · 2014-12-12T21:12:28Z

reference/forms/types/options/by_reference.rst.inc

@@ -42,4 +42,4 @@ call the setter on the parent object.
 Similarly, if you're using the :doc:`collection</reference/forms/types/collection>`
 form type where your underlying collection data is an object (like with Doctrine's
 ``ArrayCollection``), then ``by_reference`` must be set to ``false`` if you
-need the setter (e.g. ``setAuthors()``) to be called.
+need the adder and remover (e.g. ``addAuthor()`` and ``removeAuthor()``) to be called.


i feel the sentence is too long (it's even too long in its current version). What do you think about splitting this up into two sentences?

I think this is fine

weaverryan · 2015-01-01T22:41:45Z

Thanks Flo!

This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #4639). Discussion ---------- Update by_reference.rst.inc Commits ------- ba881a3 Update by_reference.rst.inc

Update by_reference.rst.inc

ba62aab

xabbuh reviewed Dec 12, 2014
View reviewed changes

xabbuh added the Status: Needs Work label Dec 12, 2014

wouterj added Status: Reviewed and removed Status: Needs Work labels Dec 28, 2014

weaverryan closed this Jan 1, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update by_reference.rst.inc #4639

Update by_reference.rst.inc #4639

docteurklein commented Dec 12, 2014

xabbuh Dec 12, 2014

wouterj Dec 12, 2014

weaverryan commented Jan 1, 2015

Update by_reference.rst.inc #4639

Update by_reference.rst.inc #4639

Conversation

docteurklein commented Dec 12, 2014

xabbuh Dec 12, 2014

Choose a reason for hiding this comment

wouterj Dec 12, 2014

Choose a reason for hiding this comment

weaverryan commented Jan 1, 2015