-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
consistent spelling #4671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
consistent spelling #4671
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5b8e84d
consistency, replace "e-mail" with "email"
xabbuh 83238aa
consisteny, use "front-end" instead of "frontend" or "front end"
xabbuh 85fb0b1
consistency, replace "save-handler" with "save handler"
xabbuh 7eb1847
unify "Symfony Standard Edition" usages
xabbuh b2d802e
use "stylesheet" instead of "Stylesheet"
xabbuh 1bd33ca
"web debug toolbar" instead of "Web Debug Toolbar"
xabbuh f8db4b0
use "object-oriented" instead of "object oriented"
xabbuh fd52cd3
use boolean instead of Boolean
9c02eda
unify EventDispatcher/event dispatcher usages
xabbuh 95c842c
use "console command" instead of "Console Command"
xabbuh b774651
unify event subscriber usages
xabbuh 5b6895a
unify exception usages
xabbuh bd5ca26
use "full-stack" instead of "full stack"
xabbuh 07bc4db
use "Form component" instead of "form framework"
xabbuh 6b7d536
use "Symfony Framework" instead of "Symfony framework"
xabbuh f182121
uppercase "dependency injection"
xabbuh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -207,7 +207,7 @@ The XML version of the config would then look like this: | |
|
||
.. note:: | ||
|
||
In the Symfony full stack framework there is a base Extension class which | ||
In the Symfony full-stack Framework there is a base Extension class which | ||
implements these methods as well as a shortcut method for processing the | ||
configuration. See :doc:`/cookbook/bundles/extension` for more details. | ||
|
||
|
@@ -347,9 +347,9 @@ will then be called when the container is compiled:: | |
|
||
.. note:: | ||
|
||
Compiler passes are registered differently if you are using the full | ||
stack framework, see :doc:`/cookbook/service_container/compiler_passes` | ||
for more details. | ||
Compiler passes are registered differently if you are using the full-stack | ||
framework, see :doc:`/cookbook/service_container/compiler_passes` for | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. uppercase the F? or should it be: |
||
more details. | ||
|
||
Controlling the Pass Ordering | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
@@ -510,5 +510,5 @@ to see if the files have changed, if they have the cache will be considered stal | |
|
||
.. note:: | ||
|
||
In the full stack framework the compilation and caching of the container | ||
In the full-stack framework the compilation and caching of the container | ||
is taken care of for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like "Event Dispatcher component".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean without the Symfony prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean with a space in the word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's not really consistent with how we use component names otherwise (e.g. HttpFoundation, DependencyInjection, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for example here we use
VarDumper component https://github.com/symfony/symfony-docs/blame/4dd1f25090fd2c5eb1f6ec2a6c2c1613bef1c856/changelog.rst#L276
think its much better than "var dumper component"
https://github.com/symfony/symfony-docs/blame/4dd1f25090fd2c5eb1f6ec2a6c2c1613bef1c856/changelog.rst#L475
so i am 👍