Remove horizontal scrollbar and other fixes #4909
Conversation
ifdattic
commented
Jan 24, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3 |
| Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |
| @@ -40,7 +40,7 @@ If you know you need a specific version of the library, add that to the command: | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| $ composer require symfony/finder | |||
| $ composer require symfony/finder:2.6.2 | |||
There was a problem hiding this comment.
I would prefer to add a space between package and version instead of a colon.
| @@ -40,7 +40,7 @@ If you know you need a specific version of the library, add that to the command: | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| $ composer require symfony/finder | |||
| $ composer require symfony/finder 2.6.2 | |||
There was a problem hiding this comment.
-1. You should not use an exact match in your composer constraint (it means composer will never give you bug fixes until you ask for them explicitly). And Composer is smart enough to guess the best constraint based on the existing versions of the package. So most of the time, the best solution is to omit the version constraint entirely
There was a problem hiding this comment.
Then in my opinion this whole block should be removed, as the text for example is about installing specific version of the library while providing the same code example as the one before. And without the version composer will install the best version not the specific one.
There was a problem hiding this comment.
It seems that @ifdattic is right because the example is specifically about using exact dependency versions.
There was a problem hiding this comment.
I agree with removing this section. wdyt @xabbuh @weaverryan
There was a problem hiding this comment.
I agree about removing it. This page is not about documenting all features of composer require, and specifying an exact match requirement is a mistake most of the time (you would want at least 2.6.* to allow getting bug fixes and security patches when running a composer update), so we should not show such example IMO
There was a problem hiding this comment.
ping @ifdattic can you please remvoe this section?
|
I really think that this PR can be considered finished and ready to be merged. |
This PR was merged into the 2.3 branch. Discussion ---------- Remove horizontal scrollbar and other fixes | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Commits ------- 11422db Update using_components.rst 9c1c071 Update using_components.rst 2e5c054 Remove horizontal scrollbar, fix command with version 759ad10 Remove horizontal scrollbar d47f5f7 Remove horizontal scrollbar
|
@weaverryan Always glad to help! |